Convert update-plugin-index to a composite action#85
Merged
Conversation
A GitHub App installation token minted in one job and passed to a reusable workflow (a separate job) is scrubbed to empty — masked values don't survive job-to-job outputs, so the reusable-workflow form couldn't actually check out the catalog repo. A composite action runs inside the caller's job, so the token is minted and used in one job and passed directly as the `token` input. Same logic and generic archive->checksum mapping as before; the cross-repo credential moves from a `PLUGIN_INDEX_TOKEN` secret to a `token` input.
Point the generated PR at the release page so reviewers can see what changed in the release the plugin is being bumped to.
This was referenced Jul 1, 2026
savme
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
update-plugin-indexreusable workflow (shipped in v1.17.0) can't actually do its job. Callers mint a GitHub App token to open the cross-repo catalog PR, but a reusable workflow runs as its own job, so the token has to cross a job boundary — and masked values are scrubbed to empty when passed through job outputs. In practice the catalog checkout failed withInput required and not supplied: token.What this changes
Converts it from a reusable workflow to a composite action (
update-plugin-index/action.yml) — the repo's first. A composite action runs inside the caller's job, so the token is minted and used in the same job and passed directly as thetokeninput (no cross-job hop). The step logic and the generic archive→checksum mapping are unchanged; the only interface change is the cross-repo credential moving from aPLUGIN_INDEX_TOKENsecret to atokeninput.update-plugin-index/action.yml..github/workflows/update-plugin-index.yaml.docs/update-plugin-index/andCLAUDE.md.Callers now mint + call in one job:
Verification
Validated end-to-end against the existing
milo-os/ipamv0.2.0 release assets, opening a real PR on a scratchmilo-os/cli-pluginsbranch (see comments).Related work